- 
                Notifications
    
You must be signed in to change notification settings  - Fork 803
 
fix: fastapi memory leak only #3688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            xrmx
  merged 16 commits into
  open-telemetry:main
from
artemziborev:fix/fastapi-memory-leak-only
  
      
      
   
  Aug 23, 2025 
      
    
                
     Merged
            
            fix: fastapi memory leak only #3688
                    xrmx
  merged 16 commits into
  open-telemetry:main
from
artemziborev:fix/fastapi-memory-leak-only
  
      
      
   
  Aug 23, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …ist to avoid memory leaks
… WeakSet and safe discard
      
        
      
      
  
    10 tasks
  
              
                    anuraaga
  
              
              approved these changes
              
                  
                    Aug 12, 2025 
                  
              
              
            
            
        
          
                .../opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
           Hi @anuraaga, just a gentle reminder — could you take a look at this PR? All checks have passed 👍  | 
    
| 
           Hi @artemziborev - LGTM. I had already approved since was just a comment nit, but I'm not a maintainer so it's a grey check  | 
    
              
                    emdneto
  
              
              reviewed
              
                  
                    Aug 15, 2025 
                  
              
              
            
            
              
                    emdneto
  
              
              reviewed
              
                  
                    Aug 15, 2025 
                  
              
              
            
            
              
                    emdneto
  
              
              approved these changes
              
                  
                    Aug 15, 2025 
                  
              
              
            
            
…to fix/fastapi-memory-leak-only
              
                    xrmx
  
              
              reviewed
              
                  
                    Aug 22, 2025 
                  
              
              
            
            
              
                    xrmx
  
              
              reviewed
              
                  
                    Aug 22, 2025 
                  
              
              
            
            
              
                    xrmx
  
              
              approved these changes
              
                  
                    Aug 22, 2025 
                  
              
              
            
            
              
                    emdneto
  
              
              approved these changes
              
                  
                    Aug 22, 2025 
                  
              
              
            
            
| 
           Hi folks, thank you for solving this issue.  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Fix FastAPI instrumentation memory leak by tracking instrumented apps with a WeakSet instead of a strong-referenced set. This avoids retaining strong references to
fastapi.FastAPIinstances, allowing them to be garbage-collected even ifuninstrument_app()isn’t called. Also aligns with the approach used in the Starlette instrumentation.Scope minimized to FastAPI only:
_instrumented_fastapi_appsanddiscard()on removaluninstrument_app()test_fastapi_instrumentation.pyFixes # (issue)
Type of change
How Has This Been Tested?
test_fastapi_app_is_collected_after_instrumentintest_fastapi_instrumentation.py, which:gc.collect()Does This PR Require a Core Repo Change?
Checklist: